[Bug 670548] Missing return value in gst-libs/gst/tag/gstxmptag.c
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Feb 21 08:20:56 PST 2012
https://bugzilla.gnome.org/show_bug.cgi?id=670548
GStreamer | gst-plugins-base | 0.10.x
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |t.i.m at zen.co.uk
Resolution| |FIXED
Target Milestone|HEAD |0.10.37
--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-02-21 16:11:07 UTC ---
Why not, but I'm fairly sure there will be more of those, because we use
G_DISABLE_ASSERT for releases.
I think it's something in your package builder that makes it fail though, not
on our side, for releases warnings should not be fatal.
I've just replaced the assert with a g_return_val_if_fail() now, so we don't
get compiler warnings about unreachable code when we compile without asserts
disabled later.
commit 5c3f7b51ce31fdcc31a2d8ef0d3154a40c1e927d
Author: Vincent Untz <vuntz at gnome.org>
Date: Tue Feb 21 16:43:59 2012 +0100
tag: xmp: Fix a build warning when compiling with asserts disabled
Return a value even if the code will never be reached, to make compilers
happy.
https://bugzilla.gnome.org/show_bug.cgi?id=670548
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list