[Bug 310775] libvisual element needs to support opengl

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=310775
  GStreamer | gst-plugins-gl | git

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202144|0                           |1
        is obsolete|                            |

--- Comment #33 from Julien Isorce <julien.isorce at gmail.com> 2012-01-03 16:43:47 UTC ---
Created an attachment (id=204506)
 View: https://bugzilla.gnome.org/attachment.cgi?id=204506
 Review: https://bugzilla.gnome.org/review?bug=310775&attachment=204506

libvisual-gl: full compatibility with projectM-libvisual if libprojectM >=
2.0.1

(In reply to comment #32)
> Switchign the window size still does not renegotiate.

Because our FBO is unbinded (see last commit). So the rendering from
libvisual_gl_projectM is directly done into the opengl back buffer instead of
our FBO. So it's not possible to chain FBOs in this case. The resizing pb is a
consequence of that.

It's not correct to unbind it before the projectM rendering but I only do it to
see something.
projectM does the rendering in several passes (it uses its own FBOs).

The correct way is to patch libprojectM. Before starting rendering it has to
detect if a FBO is currently binded. If yes it has to keep the fbo's identifier
in mind. Then it has to rebind it just before the final pass (when libprojectM
is rendering to the back buffer):

 -1: detect if a fbo is currently binded <- patch libprojectM to add this step
 -2: projectM binds its own fbo to render into it (So it cancels step 1) and
does the redering (=pass1).
 -3: bind our fbo  <- patch libprojectM to add this step
 -4: projectM's final rendering (no fbo)

Here I submitted a patch to projectM bug tracker that contains those
requirements:
https://sourceforge.net/tracker/?func=detail&aid=3468910&group_id=104201&atid=637262

If projectM accepts the patch then the following
0001-libvisual-gl-full-compatibility-with-projectM-libvis.patch attached patch
should be enough.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.