[Bug 667655] New: test/checks/elements/jifmux.c compile failure because of fail() calls with no arguments

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=667655
  GStreamer | gst-plugins-bad | 0.10.22

           Summary: test/checks/elements/jifmux.c compile failure because
                    of fail() calls with no arguments
    Classification: Platform
           Product: GStreamer
           Version: 0.10.22
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: mooney at dogbert.cc.ndsu.nodak.edu
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I searched the bug database using several different terms and didn't turn up
any previous report for this.

I'm building gst-plugins-bad-0.10.22 on x86_64-sun-solaris2.10 with the Oracle
Studio 12.2 compilers.

I get a compile failure in elements/jifmux.c when running gmake check:

        source='elements/jifmux.c' object='elements_jifmux-jifmux.o' libtool=no
\
        DEPDIR=.deps depmode=none /bin/bash ../../depcomp \
        cc -xipo=2 -xO4 -xc99=all -DHAVE_CONFIG_H -I. -I../..  
-I/local/gnu/include -I/local/gnu/include -I/local/include -D_REENTRANT
-D_PTHREADS -I/local/gnu/include/gstreamer-0.10 -I/local/gnu/include/glib-2.0
-I/local/gnu/lib/64/glib-2.0/include -I/local/gnu/include/libxml2  
-I/local/include   -D_REENTRANT -D_PTHREADS -I/local/gnu/include/gstreamer-0.10
-I/local/gnu/include/glib-2.0 -I/local/gnu/lib/64/glib-2.0/include
-I/local/gnu/include/libxml2      -g   
-DGST_TEST_FILES_PATH="\"../../tests/files\"" -UG_DISABLE_ASSERT
-UG_DISABLE_CAST_CHECKS -Xa -xO4 -xipo=2 -features=extensions -KPIC -m64
-xtarget=native -xarch=native -I/local/gnu/include -I/local/gnu/include
-I/local/include -c -o elements_jifmux-jifmux.o `test -f 'elements/jifmux.c' ||
echo './'`elements/jifmux.c
"/local/gnu/include/glib-2.0/gobject/gparam.h", line 157: warning: integer
overflow detected: op "<<"
"elements/jifmux.c", line 343: syntax error before or at: ,
"elements/jifmux.c", line 343: syntax error before or at: ,
"elements/jifmux.c", line 343: syntax error before or at: ,
"elements/jifmux.c", line 345: syntax error before or at: ,
"elements/jifmux.c", line 345: syntax error before or at: ,
"elements/jifmux.c", line 345: syntax error before or at: ,
"elements/jifmux.c", line 347: syntax error before or at: ,
"elements/jifmux.c", line 347: syntax error before or at: ,
"elements/jifmux.c", line 347: syntax error before or at: ,
"elements/jifmux.c", line 349: syntax error before or at: ,
"elements/jifmux.c", line 349: syntax error before or at: ,
"elements/jifmux.c", line 349: syntax error before or at: ,
"elements/jifmux.c", line 351: syntax error before or at: ,
"elements/jifmux.c", line 351: syntax error before or at: ,
"elements/jifmux.c", line 351: syntax error before or at: ,

and so on.  It's for every call of the
GST_COMPARE_GST_STRING_TAG_TO_EXIF_SHORT_FUNC utility macro.

Preprocessing the file and examining the results, the issue is with each call
to "fail()" in the resulting function.

The problem is that fail() is not being passed any arguments at all, so the
resulting _fail_unless call has nothing for the ## __VA_ARGS__ position (from
the installed gst/check/internal-check.h header, which comes from gstreamer
0.10.35).

If I fill in some value in the calls to fail() in that macro, and the two other
areas in jifmux.c where fail() is called with no arguments, the compile
proceeds.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.