[Bug 679490] [flacparse] TOC support
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Jul 6 01:16:33 PDT 2012
https://bugzilla.gnome.org/show_bug.cgi?id=679490
GStreamer | gst-plugins-good | git
--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-07-06 08:05:14 UTC ---
Review of attachment 218147:
--> (https://bugzilla.gnome.org/review?bug=679490&attachment=218147)
Looks good in general, thanks :)
::: gst/audioparsers/gstflacparse.c
@@ +991,3 @@
+
+ /* skip 4 bytes METADATA_BLOCK_HEADER + 395 bytes from CUESHEET_TRACK */
+ if (!gst_byte_reader_skip (&reader, 399))
Maybe say here what these 395 bytes are (link to the spec in a comment). And
the media catalog number should be put into a tag
@@ +994,3 @@
+ goto error;
+
+ if (!gst_byte_reader_get_uint8 (&reader, &tracks))
Better call the variable n_tracks to make it more obvious that ti's the number
of tracks
@@ +1004,3 @@
+ goto error;
+
+ if (!gst_byte_reader_skip (&reader, 26))
Say what these 26 bytes are. Also the ISRC should be put in a tag I guess
@@ +1012,3 @@
+ /* add chapters in cuesheet edition */
+ /* lead-out tack has number 170 */
+ if (track_num != 170) {
255 is lead-out too
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list