[Bug 669310] dvbsuboverlay: some subpictures not rendered (missing end-of-display markers)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=669310
  GStreamer | gst-plugins-bad | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24

--- Comment #11 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2012-07-09 16:24:46 UTC ---
Another quote from spec:

"The PTS in the PES packet header provides presentation timing information for
the subtitling data, and is associated with the subtitle data in all segments
carried in that PES packet. The PTS defines the time at which the associated
decoded segments should be presented. This may include removal of subtitles,
for example when an entire region is removed or when all objects in a region
are removed. There may be two or more PES packets with the same PTS valuefor
example when it is not possible or desirable to include all segments associated
to the same PTS in one PES packet. 

The complete set of segments of a subtitle service that are associated to the
same PTS is referred to as a display set. The last segment of a display set
shall be followed by an "end_of-display-set segment", which signals that no
more
subtitling data associated to a certain PTS is needed for that service before
decoding can commence. The display sets shall be delivered in their correct
presentation-order, and the PTSs of subsequent display sets shall differ by
more than one video frame period."

So, as noted above, it is not quite safe to force end-of-display-set upon each
(PES) chunk of data delivered to dvb-sub code.

Following commit forces end-of-display-set slightly safer and has subtitles
showing up as well:

commit a926d6d1186410ff83e234877cd59af6db6c2613
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Mon Jul 9 18:07:24 2012 +0200

    dvbsuboverlay: properly force end-of-display-set

    ... which is upon receiving new data with different PTS spec-wise,
    or optionally upon each packet of subtitle data if desired by property.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=669310

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.