[Bug 540891] [flac] Support embedded cuesheets
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Jul 11 03:55:13 PDT 2012
https://bugzilla.gnome.org/show_bug.cgi?id=540891
GStreamer | gst-plugins-good | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #218171|none |needs-work
status| |
--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2012-07-11 10:55:06 UTC ---
Review of attachment 218171:
--> (https://bugzilla.gnome.org/review?bug=540891&attachment=218171)
::: gst/audioparsers/gstflacparse.c
@@ +1000,3 @@
+ tags = gst_tag_list_new_empty ();
+ gst_tag_list_add (tags, GST_TAG_MERGE_APPEND, GST_TAG_EXTENDED_COMMENT,
+ catalog_number, NULL);
This is not how it's supposed to be used. The EXTENDED_COMMENT tag should be a
key=value list, see
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstTagList.html#GST-TAG-EXTENDED-COMMENT:CAPS
Also note that you should have a 129 byte character array, where the last one
is a \0
@@ +1021,3 @@
+ if (!gst_byte_reader_skip (&reader, 12))
+ goto error;
+ memcpy (isrc, map.data + gst_byte_reader_get_pos (&reader), 12);
Note that you should have a 13 byte character array, where the last one is a \0
@@ +1635,3 @@
+ gst_pad_push_event (GST_BASE_PARSE_SRC_PAD (flacparse),
+ gst_event_new_toc (flacparse->toc, FALSE));
+ gst_element_post_message (GST_ELEMENT_CAST (flacparse),
Only push the event, the message posting is handled by the sinks nowadays
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list