[Bug 677306] [wavparse] TOC support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=677306
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216572|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2012-06-17 20:22:08 UTC ---
Review of attachment 216572:
 --> (https://bugzilla.gnome.org/review?bug=677306&attachment=216572)

* In the for loop for parsing all the cue entries, just increment the data
pointer instead of alwayas doing the i*sizeof(bla) calculation

* g_free() the result of g_strdup_printf()

* Use const guint8* for the data pointer of the cue parsing function

* You can use the chunk start, block start, sample offset fields to seek more
efficiently to the TOC entries

* You need to check that the data chunk is the one given in the cues

* Didn't you want to add labl/etc parsing too? In that case you should parse
everything into some private data structure and build the TOC before parsing of
the data chunk starts. You would then connect the information of the cue
chunk(s) and the labl/etc chunks there to build the TOC

* Put the struct not into the header but into the .c file

* +  if (!wav->toc)
+    wav->toc = toc;

You should probably merge the cues. A new cue chunk would be a new edition
inside the same TOC. Also the way you do it now you're leaking the newly
created TOC

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.