[Bug 678170] osxaudiosink: respect the prefered channel layout

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=678170
  GStreamer | gst-plugins-good | 0.10.x

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216520|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2012-06-17 20:23:40 UTC ---
Review of attachment 216520:
 --> (https://bugzilla.gnome.org/review?bug=678170&attachment=216520)

+        case kAudioChannelLabel_LeftSurround:
+          pos[i] = GST_AUDIO_CHANNEL_POSITION_REAR_LEFT;
+          break;
+        case kAudioChannelLabel_RightSurround:
+          pos[i] = GST_AUDIO_CHANNEL_POSITION_REAR_RIGHT;
+          break;
+        case kAudioChannelLabel_RearSurroundLeft:
+          pos[i] = GST_AUDIO_CHANNEL_POSITION_SIDE_LEFT;
+          break;
+        case kAudioChannelLabel_RearSurroundRight:
+          pos[i] = GST_AUDIO_CHANNEL_POSITION_SIDE_RIGHT;
+          break;
+        case kAudioChannelLabel_CenterSurround:
+          pos[i] = GST_AUDIO_CHANNEL_POSITION_REAR_CENTER;
+          break;

Are you sure this is correct? I would expect:
L/R Surround => L/R Side
L/R Rear Surround => L/R Rear

But for Center Surround => Rear I have no suggestion either ;)


+      gst_caps_append_structure (caps, s);
+      if (max_channels > 2 && use_positions) {
+        s = gst_structure_copy (s);

s not valid after append_structure()!


+        gst_structure_set (s, "channels", G_TYPE_INT, max_channels, NULL);

Really? Shouldn't it allow any permutation and subset of the allowed channels?


You should for 0.10 check when configuring the ringbuffer to caps that these
caps are actually supported now for the device. Because of the caps setting
"bug" in 0.10, where core only checks against the template caps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.