[Bug 645467] gst_element_make_for_uri should return a GError

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Jun 23 07:08:44 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=645467
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-06-23 14:08:40 UTC ---
Done:

 commit f8445bd2936536b63e7d468e2f18ff8e0269123c
 Author: Tim-Philipp Müller <tim at centricular.net>
 Date:   Sat Jun 23 14:40:17 2012 +0100

    uri: add error argument to gst_element_make_from_uri()

    So callers can differentiate between there not being a
    handler for the protocol, and them not accepting the URI
    for some reason.

    https://bugzilla.gnome.org/show_bug.cgi?id=645467

Now use it ;)

On a sidenote, I'm not sure if whoever handles the DVB URI should reject it
because of some file parsing error. IMHO it shouldn't parse the file at all at
that point, just accept the URI if the syntax looks ok, and then error out with
a proper error message on the bus if there's a problem with the file. It
shouldn't parse the file in NULL state IMHO.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list