[Bug 672136] Add winks plugin to build target for autotools

Mon Mar 19 15:49:03 PDT 2012

https://bugzilla.gnome.org/show_bug.cgi?id=672136
  GStreamer | gst-plugins-bad | 0.10.22

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-03-19 22:48:55 UTC ---
Thanks for the patches. I'm not a win32/mingw person, but still a few
comments/questions:

> 1-winks Makefile: Pretty self explanatory.

Yes, looks fine.

> 2-sys Makefile: Self explanatory, but you'll probably want a configure-tunable
> switch for winks.

We need a proper configure check for the right header and/or lib I think
(AG_GST_CHECK_FEATURE).

> 3-ksvideohelpers.c: MEDIASUBTYPE_I420 is already defined by MinGW-w64. This
> should be tunable with a #if !define block.

Why didn't you just wrap it in a #ifndef MEDIASUBTYPE_I420 block then? :)

> 4-kshelpers.c: STATIC_KSPROPSETID_Wave_Queued is not defined if NTDDI_VERSION
> is greater than NTDDI_WS03 according to the MinGW-w64 header ksmedia.h. I just
> defined it in the source as a workaround.

Can we also add guards here so that it'll work everywhere?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.