[Bug 663869] GesTimelinePipeline could provide API ala playbin2 to set and get the audio and video preview sinks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663869
  GStreamer | gst-editing-services | git

Xabier Rodríguez Calvar <xrcalvar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #10 from Xabier Rodríguez Calvar <xrcalvar at igalia.com> 2012-03-28 09:39:32 UTC ---
(In reply to comment #9)
> commit 8ff7b7def5ebd0fda89cf5d8728e48aecb497461
> Author: Robert Swain <robert.swain at collabora.co.uk>
> Date:   Tue Oct 4 16:25:22 2011 +0200
> 
>     GESTimelinePipeline: Add video sink get/set API
> 
>     This new API allows getting/setting of the preview mode's video sink
>     element through playsink's video-sink property.
> 
> 
> commit edf47f880d45bd7c740603cd88e4a96b5b19bb97
> Author: Robert Swain <robert.swain at gmail.com>
> Date:   Mon Nov 7 15:08:34 2011 +0100
> 
>     GESTimelinePipeline: Add API to get/set audio sink

This bug is not about not having API for the audio and video sink. That API is
provided in the commits you mention. I am reopening the bug because I would
like this pipeline to provide the GObject property based API to set the preview
sinks as it is done for playbin2.

When I provided the first patches I was told to add more properties because the
API could become inconsistent, as you could not set all the values thru methods
or thru properties, so I added properties for the methods that had only only
one parameter, which is all you can do with properties.

As a side effect of not having this API, when I was subclassing something using
playbin2 to take advantage of the common code, I needed to add another virtual
method just to set the preview sinks, which is something that I wouldn't have
to do if the patches that I proposed were integrated.

Hence, this bug is not fixed, so reopening it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.