[Bug 673102] New: [kateenc] Fixed buffer duration
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Mar 29 11:41:40 PDT 2012
https://bugzilla.gnome.org/show_bug.cgi?id=673102
GStreamer | gst-plugins-bad | 0.10.22
Summary: [kateenc] Fixed buffer duration
Classification: Platform
Product: GStreamer
Version: 0.10.22
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gst-plugins-bad
AssignedTo: gstreamer-bugs at lists.freedesktop.org
ReportedBy: hexa00 at gmail.com
QAContact: gstreamer-bugs at lists.freedesktop.org
GNOME version: ---
There was a weird hack in kateenc that was messing up the buffers durations :
- /* Hack to flush each packet on its own page - taken off the CMML encoder
element */
- GST_BUFFER_DURATION (buffer) = G_MAXINT64;
-
This was breaking seeking in a matroska file containing kate encoded subtitles
for example with vlc, since the total track duration was completely wack...
I do no understand what " flush each packet on its own page" could mean...
unless it was like each subtitle buffer would display on a different frame but
still it makes no sense to have the wrong duration.. I checked the CMML
encoder.. found no reference or any similar code...
Also, I think if there was really a problem with the duration it should be set
to GST_CLOCK_TIME_NONE, not to G_MAXINT64...
So unless somebody has a clear idea why this is needed ?
Here's a patch to fix it by removing this "hack"
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list