[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain
bugzilla at gnome.org
Thu May 10 00:32:33 PDT 2012
GStreamer | gst-plugins-base | unspecified
--- Comment #11 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2012-05-10 07:32:08 UTC ---
Thanks for looking into that.
The pad may not be linked (so the _get_peer may return NULL), you may want to
default to a 0,-1,0 segment in this case.
Also res &= may be better as res = res && to avoid calling subsequent
conversions if the first fails, as they likely will all do at once. May not
matter much though.
_generate_update_newsegment_event might also want to skip conversion if the
format is already TIME, as your other code already does.
-1 could be changed to GST_CLOCK_TIME_NONE.
The "Subtitle segment format %s not TIME, converting" message seems to be
output on checking self->subtitle_segment.format, I think it should be format.
The patch from comment 2 was not applied, so no need to revert it in your
patch. Also can you make the new patch as:
git format-patch -1
(assuming this patch is the last one you committed to the branch you're on).
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs