[Bug 638168] textoverlay: don't return wrong-state when stopping while in text chain

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=638168
  GStreamer | gst-plugins-base | unspecified

--- Comment #24 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2012-05-14 12:57:34 UTC ---
(In reply to comment #23)
> Review of attachment 213880 [details]:
> 
> ::: gst/playback/gstplaysink.c
> @@ +1863,3 @@
> +    playsink->text_flush = FALSE;
> +    GST_PLAY_SINK_UNLOCK (playsink);
> +    gst_pad_send_event (pad, gst_event_new_flush_stop ());
> 
> This might cause problems if the flush-stop event reaches the other side of the
> subtitleoverlay, due to resetting the segments and other state. This doesn't
> happen here?

I haven't seen any side effects so far, but it might be good to be careful here
and drop it before it leaves the subtitleoverlay.

> 
> Also should this really be gst_pad_send_event() and not gst_pad_push_event()?

gst_pad_send_event looks correct to me, it is a sink pad and the event is going
downstream.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.