[Bug 667292] gstfilesrc: Check for posix_madvise(), and use it, as well as madvise()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=667292
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.37

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-05-15 18:09:18 UTC ---
I would prefer to just remove them then, I doubt they make much sense anyway:

commit 7a70c91ac37d1ece87f31d98f9d7d0333f31bfd6
Author: Idar Tollefsen <itollefs at cisco.com>
Date:   Tue May 15 19:04:39 2012 +0100

    configure: explicitly check for sys/mman.h header

    And use header-specific guards.

    https://bugzilla.gnome.org/show_bug.cgi?id=667292

commit f85885474cee78065d9aafb8eac7d74aec54cc69
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Tue May 15 18:35:58 2012 +0100

    filesrc: remove unused or questionable madvise() calls in deprecated mmap
code paths

    use-mmap functionality has been removed in 0.11 and doesn't really
    have any performance advantages in most cases anyway. Deprecate
    "sequential" property to hint sequential access in mmap mode and
    make it non-functional. Chances are no one was using this ever
    anyway, or inappropriately.

    Remove madvise() calls. We would need to do extensive configure
    checks to handle these properly on different systems, and it
    doesn't seem worth adding that for code that's already removed
    in 0.11 or questionable anyway (like madvise DONTNEED right
    before munmap).

    https://bugzilla.gnome.org/show_bug.cgi?id=667292

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.