[Bug 676739] Make stream changes using input-selector/playbin2 instantaneous

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon May 28 02:29:36 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=676739
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214960|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-28 09:29:31 UTC ---
Review of attachment 214960:
 --> (https://bugzilla.gnome.org/review?bug=676739&attachment=214960)

::: gst/playback/gstplaysink.c
@@ +1902,3 @@
+
+    custom_flush = g_strdup_printf ("custom-%s-flush", sink_type);
+    custom_flush_finish = g_strdup_printf ("custom-%s-flush-finish",
sink_type);

Maybe just hardcode the three different names here instead of doing the dynamic
string dance :)
I would suggest prefixing the event names with playsink as it's now playsink
API.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list