[Bug 676630] [0.10] matroskademux, avidemux: implement accurate keyframe snapping seeks

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=676630
  GStreamer | gst-plugins-good | unspecified

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnauw at users.sourceforge.net

--- Comment #10 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2012-05-29 18:37:50 UTC ---
There are some comments here, either on style (avoiding the noise due to !! ->
! ! changes) or on semantics (no closing segment should be sent, because one
should prevent any segment sent before knowing when/where to push).

But mainly, I seem to be missing how this code will end up at a different
keyframe than if there were no ACCURATE flag.

If no such flag, the index would be consulted to locate the keyframe ahead or
behind the requested position, and then a seek to position follows.

If such a flag, there is a seek to the (index defined) keyframe position before
the requested position.  Then scanning continues, but that scan can never find
keyframes that are not in the index, since afaik keyframe-ness is defined by
the index.

A scan might be "useful" in matroska since the index might only indicate
cluster starts, and there can be more keyframes than at cluster start
(keyframes so *optionally* marked at their position), but for avi there are
only keyframes as indicated in the index (until a parser says otherwise).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.