[Bug 687330] videobox, videomixer: height obtained using _WIDTH macros

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687330
  GStreamer | gst-plugins-good | unspecified

--- Comment #4 from Douglas Bagnall <douglas at halo.gen.nz> 2012-11-01 21:49:55 UTC ---
(In reply to comment #3)
> Thanks, pushed as separate patches (so I could describe what it actually might
> fix in case of videobox - don't know if it had any ill effects in case of
> videomixer - did it crash? cause artefacts?)

To be honest, I was only reading it.  But what seems to happen is
portrait-aligned video sources are vertically truncated to squares:

 gst-launch-1.0 videotestsrc pattern=1 ! \
  video/x-raw,format =I420, framerate=\(fraction\)10/1, width=50, height=200 !
\
  videomixer  name=mix ! videoconvert ! xvimagesink \
  videotestsrc ! \
  video/x-raw,format=I420, framerate=\(fraction\)5/1, width=100, height=400 !
mix.

The more serious variation is when the output frame size is constrained to a
smaller landscape rectangle than videomixer would invent for itself. Like this:

 gst-launch-1.0 videotestsrc pattern=1 ! \
  video/x-raw,format =I420, framerate=\(fraction\)10/1, width=250, height=200
!\
  videomixer  sink_1::ypos=50   name=mix ! videoconvert ! \
  video/x-raw, width=200, height=200 ! xvimagesink \
  videotestsrc ! \
  video/x-raw,format=I420, framerate=\(fraction\)5/1, width=300, height=200 ! \
  mix.

That's a crash, because videomixer mistakes width for height and overruns the
buffer.

Sorry for the mixed up patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.