[Bug 687380] New: videomixer: Y offset should be compared to height, not width

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687380
  GStreamer | gst-plugins-good | unspecified

           Summary: videomixer: Y offset should be compared to height, not
                    width
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: douglas at halo.gen.nz
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=227844)
 View: https://bugzilla.gnome.org/attachment.cgi?id=227844
 Review: https://bugzilla.gnome.org/review?bug=687380&attachment=227844

A patch

As with bug 687330, videomixer mixes up its axes. From the patch:

    /* If x or y offset are larger then the source it's outside of the picture
*/ \
-  if (xoffset > src_width || yoffset > src_width) { \
+  if (xoffset > src_width || yoffset > src_height) { \
     return; \

And quoting the commit message:

This could have prevented images showing that should have when the
source height is greater than its width.

When width exceeds height, as is common, it probably only caused a
miniscule amount of unnecessary work.  I haven't tested.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.