[Bug 687471] rtsp: fix memory leaks under error conditions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687471
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-11-02 19:43:01 UTC ---
I don't know about these. I'm tempted to WONTFIX these.

We never care about memory leaks as a result of g_return_*() - those are just
sanity checks to help spot programming bugs during development, rather than
crashing right away.

But even if not, functions that take ownership of arguments should do so at
*all* times, whether they then return an error or not, so it should never be
the caller freeing stuff after giving away ownership, that's just wrong calling
conventions IMHO.

However, I see that this is handled like this elsewhere in the code.. (e.g.
gst_rtsp_message_add_header).

So in a way my objection to this patch is that it perpetuates this madness even
more ;)

Setting to NEEDINFO, to see what other developers (and the reporter) think.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.