[Bug 687655] videocrop: Add support for automatic cropping (GST 0.10)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687655
  GStreamer | gst-plugins-good | 0.10.x

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228235|none                        |needs-work
             status|                            |

--- Comment #6 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2012-11-06 17:17:40 UTC ---
Review of attachment 228235:
 --> (https://bugzilla.gnome.org/review?bug=687655&attachment=228235)

The actual patch looks good, the test has a little issue.

::: tests/check/elements/videocrop.c
@@ +183,3 @@
+  ctx->filter2 = gst_element_factory_make ("capsfilter", "filter2");
+  fail_unless (ctx->filter != NULL,
+      "Failed to create second capsfilter element");

Is that filter2 element used anywhere? It seems to be never added to a pipeline
and never linked? You only set the outcaps on it, so they're in effect ignored.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.