[Bug 687655] videocrop: Add support for automatic cropping (GST 0.10)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687655
  GStreamer | gst-plugins-good | 0.10.x

--- Comment #8 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2012-11-06 18:03:05 UTC ---
(In reply to comment #6)
> Review of attachment 228235 [details]:
> 
> The actual patch looks good, the test has a little issue.
> 
> ::: tests/check/elements/videocrop.c
> @@ +183,3 @@
> +  ctx->filter2 = gst_element_factory_make ("capsfilter", "filter2");
> +  fail_unless (ctx->filter != NULL,
> +      "Failed to create second capsfilter element");
> 
> Is that filter2 element used anywhere? It seems to be never added to a pipeline
> and never linked? You only set the outcaps on it, so they're in effect ignored.

My bad, updated in both bugs, the check should be on filter2, and the element
should be added and linked. The caps are being set on the element for each
tests.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.