[Bug 687471] rtsp: fix memory leaks under error conditions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687471
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |WONTFIX
   Target Milestone|HEAD                        |NONE

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-11-06 19:00:40 UTC ---
> Thinking about this corner case it can be fixed this way. It's a bit ugly but
> it works. If you agree I can make a patch with this fix.
> 
> #include <glib.h>
> 
> void
> main()
> {
>   gchar *x = g_strdup ("eserse");
>   g_return_if_fail (NULL != NULL || (
>           {
>             g_free (x);
>             FALSE;
>           }
>       ));
> }


Yeah, let's not do that. I think this is using a gcc and/or c99 extension
anyway, but it could probably be done differently as well; but still, let's
not.

I would suggest you either teach coverity or whatever tool you're using about
g_return_*(), or make it process things with -DG_DISABLE_ASSERTS (or whatever
the right define is).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.