[Bug 687464] speexdec: Don't unmap or finish_frame an invalid GstBuffer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687464
  GStreamer | gst-plugins-good | 1.0.2

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.0.3
           Severity|normal                      |critical

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-11-06 20:17:16 UTC ---
Pushed, with minor style change for better (IMHO) readability.

 commit 8c44361bca80fa4ed2ec6005c624343c7f4ec866
 Author: Debarshi Ray <rishi at gnu.org>
 Date:   Fri Nov 2 16:39:28 2012 +0100

    speexdec: Don't unmap or finish_frame an invalid GstBuffer

    https://bugzilla.gnome.org/show_bug.cgi?id=687464


This whole parse_data() function looks a bit weird, and I'm not convinced it's
quite right to do finish_frame(NULL,1) if we've just skipped over one single
sub-frame as well, but that's something to fix/test for some other time I
guess.

gst-launch line to reproduce the issue:

 gst-launch-1.0 audiotestsrc ! speexenc ! rtpspeexpay ! breakmydata
probability=0.05 ! rtpspeexdepay ! speexdec ! pulsesink

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.