[Bug 687927] New: [PATCH] xingmux doesn't compute the right number of frames

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687927
  GStreamer | gst-plugins-ugly | 0.10.19

           Summary: [PATCH] xingmux doesn't compute the right number of
                    frames
    Classification: Platform
           Product: GStreamer
           Version: 0.10.19
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: kassoulet at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=228479)
 View: https://bugzilla.gnome.org/attachment.cgi?id=228479
 Review: https://bugzilla.gnome.org/review?bug=687927&attachment=228479

patch

As reported here: https://bugs.launchpad.net/soundconverter/+bug/1075497
The xing header frames count in mp3 generated with gstreamer's xingmux always
have two frames missing.

After a verification of the xingmux code, I propose a small fix:

First, the xing header frame is never added to the count, we have to increment
the count.
Secondly, there is a rounding error when calculating the frame duration, as
spf*GST_SECOND/rate is not an integer (26122448.9) an it must be 26122449.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.