[Bug 687899] queue event handling broken with unlinked queue and sticky events

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687899
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228438|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2012-11-09 10:31:16 UTC ---
Review of attachment 228438:
 --> (https://bugzilla.gnome.org/review?bug=687899&attachment=228438)

::: plugins/elements/gstqueue.c
@@ +781,3 @@
+          if (!GST_EVENT_IS_STICKY (event) ||
+              GST_EVENT_TYPE (event) == GST_EVENT_EOS)
+            goto out_flushing;

Shouldn't this be a better label? It's not flushing, it's an error... having
different debug output for that would be useful.

Other than that this looks good to me

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.