[Bug 687991] videodecoder: add getter for QoS proportion

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687991
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228572|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2012-11-09 15:40:17 UTC ---
Review of attachment 228572:
 --> (https://bugzilla.gnome.org/review?bug=687991&attachment=228572)

IMHO can be added to 1.0, that shouldn't be a problem

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3170,3 @@
+  g_return_val_if_fail (GST_IS_VIDEO_DECODER (decoder), 1);
+
+  return decoder->priv->proportion;

Needs to use the object lock here

::: gst-libs/gst/video/gstvideodecoder.h
@@ +354,3 @@
                             GstVideoCodecFrame *frame);

+gdouble          gst_video_decoder_get_qos_proportion (GstVideoDecoder
*decoder);

I would do something like
gst_video_decoder_get_qos_whatever (decoder, &proportion, &earliest_time,
other_fields)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.