[Bug 688251] xvimagesink: don't leave the ref to the pool in case of re-negotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=688251
  GStreamer | gst-plugins-base | git

--- Comment #4 from Wim Taymans <wim.taymans at gmail.com> 2012-11-21 14:28:38 UTC ---
(In reply to comment #3)
> (In reply to comment #1)
> > This is not correct. The sink only keeps a ref to its pool when it gets a caps
> > event and when it actually negotiates to the format.
> > 
> > In the allocation query, the sink proposes a bufferpool. If the requested
> > format is the same as the currently negotiated format, it can propose that
> > pool, otherwise it needs to make a new one.
> 
> so you meant the the sink doesn't need to keep the ref to the pool, even though
> it is a new pool created in propose_allocation ? Then the sink is keeping ref
> to a pool(created in set_caps) which is not using by the upstream
> elements,,right?

Yes, correct.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.