[Bug 688251] xvimagesink: don't leave the ref to the pool in case of re-negotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=688251
  GStreamer | gst-plugins-base | git

--- Comment #8 from sreerenj <bsreerenj at gmail.com> 2012-11-21 22:11:58 UTC ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > okay,,is that scenario right??seems like tool pool active at the same time !!
> > 
> > hm,,sorry for the spelling mistake :(
> > okay,,is that scenario right??seems like two pools active at the same time !!
> 
> What could be done is disable the pool from setcaps if a buffer with a
> different pool arrives.

you mean we have to unref the dirty pool when the buffer received in
show_frame() ?...

hm,,i am again bit confused about the current implementaion

for eg:
there are two cases (the sink is creating pool in both cases)

case1: If there is no renegotiation happened in the pipeline: the pool will be
active even though the upstream elements drop the ref to the pool since the
sink is holding the reference to the pool

case2: If renegotiation happens once: then upstream element can drop ref to the
pool and which may lead to pool-deactivation since the sink doesn't hold any
ref to the pool.

is this scenario is correct?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.