[Bug 688935] New: rtpjitterbuffer not always correctly warns about resetting skew

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=688935
  GStreamer | gst-plugins-good | git

           Summary: rtpjitterbuffer not always correctly warns about
                    resetting skew
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: v.markovtsev at samsung.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


gst/rtpmanager/rtpjitterbuffer.c, near line 457:

  if (ABS (delta - jbuf->skew) > GST_SECOND) {
    GST_WARNING ("delta - skew: %" GST_TIME_FORMAT " too big, reset skew",
        GST_TIME_ARGS (delta - jbuf->skew));
    rtp_jitter_buffer_resync (jbuf, time, gstrtptime, ext_rtptime, TRUE);
    send_diff = 0;
    delta = 0;
  }

If (delta - jbuf->skew) < 0, the warning will print the negative time (a really
big number). In my case, this actually happens. I suggest to add ABS:

GST_WARNING ("delta - skew: %" GST_TIME_FORMAT " too big, reset skew",
        GST_TIME_ARGS (ABS (delta - jbuf->skew)));

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.