[Bug 688251] xvimagesink: don't leave the ref to the pool in case of re-negotiation

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 26 01:14:33 PST 2012


https://bugzilla.gnome.org/show_bug.cgi?id=688251
  GStreamer | gst-plugins-base | git

--- Comment #11 from Wim Taymans <wim.taymans at gmail.com> 2012-11-26 09:14:28 UTC ---
(In reply to comment #10)
> Can you reopen the bug based on comment 5,6 and 7 ??
> 
> or the better way is to unref the dirty pool in propose_allocation itself...
> propose_allocation:
>   if new_poo_created_in_propose_allocation then   
>      unref the dirty pool

No, the pool in propose_allocation has nothing to do with the pool used for
rendering. The pool is a *proposal* based on the caps of the upstream element
that is free to use the pool or not.

The current code is correct.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list