[Bug 689107] mpegtsmux: crashes when re-used

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=689107
  GStreamer | gst-plugins-bad | git

--- Comment #3 from krzysztof.konopko at youview.com 2012-11-26 20:36:52 UTC ---
(In reply to comment #2)
> (From update of attachment 229936 [details])
> Thanks for the patch. While this probably fixes your problem, I don't think
> it's entirely right yet.
> 
> Instead of memsetting the programs, it should probably iterate over them and
> tsmux_program_free() those that are non-NULL, no?

No, the actual programs are freed in tsmux_free(). The programs array in the
derived class only keeps references to them.

> Supported by valgrind as well:

The first leak is in the test itself and obvious to fix. The second one is some
inconsistency in the state transition in the mpegtsmux element, i. e.
mpegtsmux_reset() should iterate over the mux->streamheader list and release
the resources that valgrind complains about. Looks like mpegtsmux_reset() is
not called during one of the transitions.

I'll have a look.

And thanks for pointing these out. I don't have all good habits yet ;) (missed
valgrind-devel package).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.