[Bug 685213] rtph264pay: pushing unmapped data.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=685213
  GStreamer | gst-plugins-good | unspecified

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225486|none                        |needs-work
             status|                            |

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2012-10-01 20:33:51 UTC ---
Review of attachment 225486:
 --> (https://bugzilla.gnome.org/review?bug=685213&attachment=225486)

::: gst/rtp/gstrtph264pay.c
@@ +949,3 @@
+      gst_buffer_append_memory (outbuf,
+          gst_memory_new_wrapped (GST_MEMORY_FLAG_READONLY, (guint8 *) data,
+              size, 0, size, NULL, NULL));

I don't think using  gst_memory_new_wrapped () here is correct either, as it
relies on the buffer staying in the payloader, it should probably also be
sub-buffered.

@@ +951,3 @@
+              size, 0, size, NULL, NULL));
+    else
+      outbuf = gst_buffer_append (outbuf, paybuf);

Here it eats a ref to the buffer...

@@ +1026,3 @@
+        sub =
+            gst_buffer_copy_region (paybuf, GST_BUFFER_COPY_MEMORY, pos,
+            limitedSize);

But here it doesn't eat the ref, so I guess paybuf is leaked

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.