[Bug 685726] New: [audioencoder] Timestamp and buffer tracking not threadsafe

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=685726
  GStreamer | gst-plugins-base | git

           Summary: [audioencoder] Timestamp and buffer tracking not
                    threadsafe
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: NEW
          Severity: critical
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: slomo at circular-chaos.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


The audio decoder base class passes buffers from gst_adapter_map() to the
subclass via handle_frame(), and flushes them from the adapter in
finish_frame(). For elements that have a different streaming thread for the
srcpad and call finish_frame() from a different thread (gst-omx, gst-amc,
probably others) this means that the subclass can be in handle_frame() using
the mapped data while the srcpad streaming thread is doing finish_frame() for
another frame and flushing data from the adapter.

This can cause usage of freed memory in handle_frame() and most likely also
breaks timestamp tracking in interesting ways.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.