[Bug 685890] New: codecparsers: h264: fix rbsp_more_data() implementation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=685890
  GStreamer | gst-plugins-bad | git

           Summary: codecparsers: h264: fix rbsp_more_data()
                    implementation
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: gb.devel at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=226177)
 View: https://bugzilla.gnome.org/attachment.cgi?id=226177
 Review: https://bugzilla.gnome.org/review?bug=685890&attachment=226177

codecparsers: h264: fix rbsp_more_data() implementation

Hi, this patch accounts for trailing zero bits when checking for
bsp_more_data().

In particular, fix an hypothetical stream whereby rbsp_more_data() is called in
the following conditions for PPS header: NalReader reached position 20, 12 bits
are remaining and trailing data at current byte position is c8 00.

rbsp_more_data() used to return TRUE whereas it should obviously return FALSE
because x8 00 represents a valid rbsp_trailing_bits() structure.

The stream is not so hypothetical since this is the following one:
http://samples.mplayerhq.hu/V-codecs/h264/sony-hdr-cx6-avchd-interlaced-decoding-problem/sony-hdr-cx-6-avchd-1080i-3-seconds.mts

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.