[Bug 664312] rtpvorbispay does not handle headers in caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=664312
  GStreamer | gst-plugins-good | 0.10.30

Aleix Conchillo Flaqué <aleix> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201635|0                           |1
        is obsolete|                            |

--- Comment #3 from Aleix Conchillo Flaqué <aleix at oblong.com> 2012-10-12 00:48:22 UTC ---
Created an attachment (id=226304)
 View: https://bugzilla.gnome.org/attachment.cgi?id=226304
 Review: https://bugzilla.gnome.org/review?bug=664312&attachment=226304

rtpvorbispay: use headers in caps if not previsouly found

It's been a while. Sorry for the long delay.

I have added the array type checking as suggested.

I can't see the buffer leak that you mention. The buffer if "parse_id_failed"
(in gst_rtp_vorbis_pay_handle_header_caps) is hit, is obtained from
gst_value_get_buffer, and according to the documentation we don't have a
reference to it (see below).

I would be really happy to fix the leak if you could give me an extra hint.

Thanks!

-----

#define   gst_value_get_buffer(v)   GST_BUFFER_CAST (g_value_get_boxed(v))

Receives a GstBuffer as the value of v. Does not return a reference to the
buffer, so the pointer is only valid for as long as the caller owns a reference
to v.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.