[Bug 685637] [PATCH] [audioresample] Performance improvements & ARM NEON support

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Oct 12 00:03:04 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=685637
  GStreamer | gst-plugins-base | 1.0.0

--- Comment #6 from Carlos Rafael Giani <dv at pseudoterminal.org> 2012-10-12 07:02:59 UTC ---
(In reply to comment #5)
> Are these changes to the speex resampler code upstream already? If they are,
> please just merge the speex resample code from upstream in a single, separate
> commit. If they are not, please first merge the latest speex resample code from
> upstream in a separate commit before changing code in there to make it easier
> to maintain this. And also update the diff against upstream in the README file
> in the end.
> 
> Other than that these changes look good.

Looking at the Speex git repository, the last changes to the resampler were
done in 2009-06-18 . According to the audioresample README, its Speex resampler
snapshot was taken 2009-11-10. A code comparison shows only formatting changes
(spaces etc.) and GStreamer specific additions (preprocessor define directives,
allocators, etc.). The changes in the README are incomplete, though.

So I don't think the resampler code needs an upstream update, since upstream is
pretty much dead (makes sense - Opus makes Speex obsolete). I'll see if I can
update the README file.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list