[Bug 681459] gstrtmpsink: memory leak

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681459
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.0.2

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-10-12 22:16:36 UTC ---
Thanks for the patch, pushed with minor changes: using 'ret' for the return
value variable name (more in line with code elsewhere) and free() the AVal
string, rather than g_free() it, since it was allocated with malloc not
g_malloc().

 commit 65add5533aecfb30c866bd0412189b63a7a7e096
 Author: David Régade <dregade at viewsurf.com>
 Date:   Fri Oct 12 23:09:06 2012 +0100

    rtmpsink: fix memory leak from URI verification via RTMP_ParseURL()

    In gst_rtmp_sink_uri_set_uri(), a test is performed in order
    to be sure uri is correct for librtmp. This test calls
    RTMP_ParseURL with 3 AVal pointers as parameters: host,
    playpath and app.

    AVal is a struct with a char* + int. After RTMP_ParseURL call,
    host.av_val and app.av_val both refer a substring of "uri". But
    playpath.av_val may be the result of a malloc so it needs to
    be freed.

    https://bugzilla.gnome.org/show_bug.cgi?id=681459


A patch in git format-patch would be great next time!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.