[Bug 685637] [PATCH] [audioresample] Performance improvements & ARM NEON support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=685637
  GStreamer | gst-plugins-base | 1.0.0

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225969|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge <slomo at circular-chaos.org> 2012-10-14 09:08:40 UTC ---
Review of attachment 225969:
 --> (https://bugzilla.gnome.org/review?bug=685637&attachment=225969)

::: gst/audioresample/resample.c
@@ +480,3 @@
     SSE_END (INNER_PRODUCT_SINGLE)
 #endif
+    out[out_stride * out_sample++] = sum;

Why is the SATURATE32PSHR moved above the OVERRIDE_INNER_PRODUCT_SINGLE case?
Shouldn't it stay at the same place because sum is changed in that case?

@@ +619,3 @@
     SSE_END (INTERPOLATE_PRODUCT_SINGLE)
 #endif
+    out[out_stride * out_sample++] = sum;

Same here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.