[Bug 683098] videodecoder: log failure message if acquire_buffer failed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=683098
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.0.2
            Summary|videodecoder:throw error    |videodecoder: log failure
                   |message if acquire_buffer   |message if acquire_buffer
                   |failed                      |failed
           Severity|normal                      |minor

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-10-17 10:14:45 UTC ---
Yes, an error message is not right here IMHO, failure to alloc a buffer could
be for perfectly normal reasons (flushing, shut down). I have pushed this now:

commit efff57d49746b37100f5137ed55fccd6399774e4
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Oct 17 10:55:01 2012 +0100

    videodecoder: return NULL from _allocate_output_buffer() if alloc fails

    .. instead of garbage pointer. Also log failure in debug log.
    Should've returned the flow return like _allocate_output_frame().

    https://bugzilla.gnome.org/show_bug.cgi?id=683098


You should use _alloc_output_frame() whenever possible.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.