[Bug 683782] Segfault in pulsesink.c:2077 gst_pulsesink_pad_acceptcaps()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=683782
  GStreamer | gst-plugins-good | 0.10.31

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-10-18 10:35:12 UTC ---
Created an attachment (id=226722)
 View: https://bugzilla.gnome.org/attachment.cgi?id=226722
 Review: https://bugzilla.gnome.org/review?bug=683782&attachment=226722

pulsesink: in accept_caps() check if ring buffer is NULL before de-referencing

Line 2077 from 0.10.31 was:

  /* Either template caps didn't match, or we're still in NULL state */
  if (!ret || !pbuf->context)
    goto done;

So a crash here could only be caused by pbuf being NULL.

  GstPulseRingBuffer *pbuf = GST_PULSERING_BUFFER_CAST (GST_BASE_AUDIO_SINK
(psink)->ringbuffer);

Not sure why/when this would happen though, but it might be possible during
shutdown I guess.

Code looks similar in 1.0. Attached patch might help.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.