[Bug 654853] multifilesrc: always honour stop-index

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654853
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.1
            Summary|[patch] multifilesrc: fix   |multifilesrc: always honour
                   |loop code                   |stop-index

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-10-26 10:02:03 UTC ---
Right, so I think you're onto something here, and I've committed part of your
patch.

However, I have not committed the bits that touch the
file-not-found-or-read-error bits, because it doesn't look right to me to just
remove it. That code looks useful, in the sense that it makes sure that if
we're in loop mode and wrap around to the start, and there's no start file, we
don't end up in a loop. Also, it handles the looping case from START-X where
the stop-index is not known and we just wrap around when the next file can't be
found.

commit 40117be0605e447a3321897c52e37e885b12249e
Author: Tim-Philipp Müller <tim at centricular.net>
Date:   Fri Oct 26 10:55:28 2012 +0100

    tests: add multifilesrc test for fix in previous commit

    Make sure the stop-index set is honoured.

    https://bugzilla.gnome.org/show_bug.cgi?id=654853

commit 3f2363fa57bea944686e37abf5e937e8947ada06
Author: Stas Sergeev <stsp at aknet.ru>
Date:   Fri Oct 26 10:33:03 2012 +0100

    multifilesrc: fix stop index handling

    Make sure the stop index is always honoured. Avoids
    endless loop if one wants to read and output the same
    file N times, for example.

    https://bugzilla.gnome.org/show_bug.cgi?id=654853

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.