[Bug 697162] New: SDP library is not parsing correctly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697162
  GStreamer | gst-plugins-base | 1.0.6

           Summary: SDP library is not parsing correctly
    Classification: Platform
           Product: GStreamer
           Version: 1.0.6
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: santoscadenas at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Try to parse this SDP:

v=0
o=- 123456 0 IN IP4 127.0.0.1
s=TestSession
c=IN IP4 127.0.0.1
t=0 0
m=video 3434 RTP/AVP 96 97
a=rtpmap:96 MP4V-ES/90000
a=rtpmap:97 H263-1998/90000
a=sendrecv
m=audio 4545 RTP/AVP 14
a=recvonly


then convert the GstSDPMessage back to text and you get:

v=0
o=- 123456 0 IN IP4 127.0.0.1
s=TestSession
e=NONE
c=IN IP4 127.0.0.1
m=video 3434/4294967295 RTP/AVP 96 97
a=rtpmap:96 MP4V-ES/90000
a=rtpmap:97 H263-1998/90000
a=sendrecv:
m=audio 4545/4294967295 RTP/AVP 14
a=recvonly:


I can see three problems here:

1. The library is including the email line by default, that is not necessary
according to the new rfc4566.
2. A colon is added before attributes that only have a key
3. The Number of ports is invalid, indicating 4294967295

As a solution I attach three patched, one for each problem, that can be
squashed if the mantainer consider that are very small.

I think that this patches should be included in 0.10, 1.0 and master branch,
but I've only tested them against 1.0.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.