[Bug 682629] decodebin: won't expose unknown pads even with expose-all-streams=true

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=682629
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #222356|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-04 09:35:14 UTC ---
Review of attachment 222356:
 --> (https://bugzilla.gnome.org/review?bug=682629&attachment=222356)

Looks almost good, I just don't know if there are any negative implications
when exposing the unknown streams. Can't think of any right now

::: gst/playback/gstdecodebin2.c
@@ +1459,2 @@
   if (gst_caps_is_any (caps))
     goto any_caps;

This will now crash if caps==NULL

@@ +1460,3 @@
     goto any_caps;

   dpad = gst_decode_pad_new (dbin, pad, chain);

And this

@@ -1713,3 @@
-      gst_decode_bin_expose (dbin);
-    }
-    EXPOSE_UNLOCK (dbin);

You should still check if the chain is complete and expose then here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.