[Bug 696549] wavparse: add 'note' chunk support
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Apr 9 13:01:34 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=696549
GStreamer | gst-plugins-good | git
Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #240825|none |reviewed
status| |
--- Comment #6 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-04-09 20:01:29 UTC ---
Review of attachment 240825:
--> (https://bugzilla.gnome.org/review?bug=696549&attachment=240825)
::: gst/wavparse/gstwavparse.c
@@ +1383,3 @@
+ }
+ gst_tag_list_add (tags, GST_TAG_MERGE_PREPEND, GST_TAG_COMMENT,
+ cur_subentry = gst_toc_find_entry (toc, id);
This looks like duplicated code. Could you extract this into a little helper
and use this here two times instead?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list