[Bug 697103] [PATCH] osxaudio: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697103
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241480|none                        |needs-work
             status|                            |

--- Comment #25 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-14 07:18:31 UTC ---
Review of attachment 241480:
 --> (https://bugzilla.gnome.org/review?bug=697103&attachment=241480)

Yes, thanks :) Just one other small issue with this:

::: sys/osxaudio/gstosxaudiosink.c
@@ -621,3 @@
-    gst_structure_remove_fields (out_s, "channels", "channel-mask", NULL);
-    gst_structure_set (out_s, "channels", G_TYPE_INT, max_channels,
-        "channel-mask", GST_TYPE_BITMASK, channel_mask, NULL);

get_allowed_caps() and get_caps() should still return the channel-mask in the
caps to make sure upstream does not provide channel layouts that are
unsupported

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.