[Bug 697806] avdec_h264 Fails during error recovery after packet loss leading to stream corruption

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697806
  GStreamer | gst-libav | 1.0.5

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241419|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-15 08:34:06 UTC ---
Review of attachment 241419:
 --> (https://bugzilla.gnome.org/review?bug=697806&attachment=241419)

Looks good to me in general, just some comments

::: ext/libav/gstavviddec.c
@@ +694,3 @@
+     * otherwise it should allocate a new buffer
+     * and copy across to it (which is what
+     * avcodec_default_reget_buffer does).

Yes, want to fix that in another patch on top of this? :)

@@ +1130,3 @@
+  picture->opaque = NULL;
+  GST_DEBUG_OBJECT (ffmpegdec, "Now decoding into picture %p opaque %p",
+      picture, picture->opaque);

Why do you set picture->opaque to NULL here? (And then print picture->opaque)

@@ +1213,3 @@

+  if (picture != NULL) {
+    av_free (picture);

This doesn't seem to be called in the error cases above (no_output,
negotiation_error, no_frame, etc) and is causing a leak

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.