[Bug 698712] playbin: autoplug video decoder and sink based on caps features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698712
  GStreamer | gst-plugins-base | git

--- Comment #10 from sreerenj <bsreerenj at gmail.com> 2013-04-24 13:29:00 UTC ---
@@ +3725,3 @@
+          ve = (GstVideoElement *) tmp->data;
+          if (!ve->is_dirty && factory == ve->vdec) {
+            ve->is_dirty = 1;

This is not threadsafe, and why is this loop necessary at all? Shouldn't the
overall loop only be over all velements that have factory==ve->vdec?

suppose the factory is not compatible with the sink element during caps
compatibility check (line_no: 3772 to 3781) , then  it will go for second
iteration of while() before returning GST_AUTOPLUG_SELECT_SKIP. During the
second iteration of while() , it should check for other possible factory-sink
combination in the velement list also (which is not already checked==not
dirty). 

Am i missing something? 

sorry for the thread-safty error :(

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.