[Bug 705982] New: Mp4mux : Box name string is not NULL terminated

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705982
  GStreamer | gst-plugins-good | 1.0.8

           Summary: Mp4mux : Box name string is not NULL terminated
    Classification: Platform
           Product: GStreamer
           Version: 1.0.8
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jagadishkamathk at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


As per MP4 standard, the box name string should be NULL terminated. Instead, we
are inserting the size first(1 Byte) and then inserting whole of string(without
'\0')

I just got this issue when I passed the generated MP4 file through an MP4
analyser

The fix is to replace line:1524-1525
1524  prop_copy_size_string ((guint8 *) hdlr->name, strlen (hdlr->name),
buffer,
1525      size, offset);

with
1524  prop_copy_fixed_size_string (hdlr->name, strlen (hdlr->name), buffer,
size, offset);
1525  prop_copy_uint8(0, buffer, size, offset);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.