[Bug 691462] typefind ADTS/AAC wrongly detected as MP2
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Aug 14 08:31:21 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=691462
GStreamer | gst-plugins-base | git
--- Comment #10 from yang.jie at intel.com 2013-08-14 15:31:16 UTC ---
(In reply to comment #8)
> Review of attachment 251583 [details]:
> Can you attach this in "git format-patch" format?
> ::: gst/typefind/gsttypefindfunctions.c
> @@ +1036,3 @@
> + offset += len;
> +
> + /* find more aac sync to select correctly */
> I think it would be better to move this into a loop instead of duplicating the
> same code 3 times. Also I think if we found that many frames in the correct
> distances it is safe to give maximum probability :)
Sebastian, you are right. new patch as attached.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list